Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rds): support 10.11.9, 10.6.19, 10.5.26 for MariaDB #31366

Merged
merged 4 commits into from
Sep 9, 2024
Merged

chore(rds): support 10.11.9, 10.6.19, 10.5.26 for MariaDB #31366

merged 4 commits into from
Sep 9, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Sep 8, 2024

Add new minor versions.

Ref: Amazon RDS for MariaDB supports minors 10.11.9, 10.6.19, 10.5.26

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 8, 2024 04:42
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 8, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 8, 2024
moelasmar
moelasmar previously requested changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mazyu36 for your contribution. I just have one comment, although it is just an update in enum values, but could you please add some unit test cases for these new values, so we can avoid any removal for these values by mistake in the future.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 8, 2024
@mergify mergify bot dismissed moelasmar’s stale review September 9, 2024 07:32

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 9, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Sep 9, 2024

@moelasmar
Thank you. I've added unit tests for MariaDB versions, excluding the deprecated ones.

moelasmar
moelasmar previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mazyu36 for your contribution

@mergify mergify bot dismissed moelasmar’s stale review September 9, 2024 08:59

Pull request has been modified.

@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1d70cd9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7abe8fc into aws:main Sep 9, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
@mazyu36 mazyu36 deleted the rds-maria-minor branch September 9, 2024 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moelasmar moelasmar moelasmar approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mazyu36 @aws-cdk-automation @moelasmar